Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Google Services library to 11.8.0 #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
*.iml
.gradle
/local.properties
/.idea/workspace.xml
/.idea/tasks.xml
/.idea/libraries
.DS_Store
build
/captures
.externalNativeBuild
.idea/caches/build_file_checksums.ser
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
<a href="https://play.google.com/store/apps/details?id=com.amalbit.animationongooglemap"><img src="https://play.google.com/intl/en_us/badges/images/generic/en_badge_web_generic.png" alt="Build Status" width="30%"></a>

## Usage
If you want to build a debug version of this demo don't forget to insert a Google Maps API Key (follow steps [here](app/src/debug/res/values/google_maps_api.xml))

Replace SupportMapFragment with TrailSupportMapFragment.

```
Expand Down
8 changes: 7 additions & 1 deletion app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@ dependencies {
})
compile 'com.android.support:appcompat-v7:26.1.0'
compile 'com.android.support:design:26.1.0'
compile 'com.google.android.gms:play-services-base:10.0.1'
def playServicesVersion = '11.8.0'
implementation("com.google.android.gms:play-services-base:$playServicesVersion") {
force = true
}
implementation("com.google.android.gms:play-services-maps:$playServicesVersion") {
force = true
}
compile 'com.android.support.constraint:constraint-layout:1.0.2'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not also change other libraries to implementation alltogether?

testCompile 'junit:junit:4.12'
implementation project(':trail')
Expand Down
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-08-21-46-07-655.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-13-02-758.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-13-20-094.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-13-22-852.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-14-21-740.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-14-23-102.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-15-05-052.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-15-47-672.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-15-49-217.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-18-12-476.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-18-13-655.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-20-40-693.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-20-41-647.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-21-36-950.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-21-38-191.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-22-18-074.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-22-27-018.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-22-53-821.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-23-20-994.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-25-55-170.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-25-55-987.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-29-14-245.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-30-16-369.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-30-23-157.json

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion build/android-profile/profile-2017-11-10-13-30-44-571.json

This file was deleted.

Binary file not shown.
9 changes: 6 additions & 3 deletions trail/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,13 @@ android {
dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])

def playServicesVersion = '11.4.2'
def playServicesVersion = '11.8.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newest version is 15.0.1. Have you test 15.0.1 with this repo? @j05u3

Copy link
Author

@j05u3 j05u3 Sep 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested with 15.0.1, only with 11.8.0

def additiveAnimVersion = '1.3.1'
compile "com.google.android.gms:play-services-maps:$playServicesVersion"
compile "at.wirecube:additive_animations:$additiveAnimVersion"
implementation("com.google.android.gms:play-services-maps:$playServicesVersion")
implementation ("at.wirecube:additive_animations:$additiveAnimVersion") {
exclude group: "com.android.support" // let play services handle the support library
exclude group: "com.google.android.gms"
}

testImplementation 'junit:junit:4.12'
androidTestImplementation 'com.android.support.test:runner:1.0.1'
Expand Down