Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Evaluators for Urban Infrastructure Model Components #267

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

WIP: Evaluators for Urban Infrastructure Model Components #267

wants to merge 13 commits into from

Conversation

saubhagya-gatech
Copy link
Contributor

@saubhagya-gatech saubhagya-gatech commented Jul 25, 2024 •
edited
Loading

Evaluators for:

  • Gate structures: Moves water from river/canals channels to lateral storage area based on gate flow curves.
  • Pump systems: Stage-based pump model: Moves water from one region to another based on stage-difference, maximum elevation in the pumpline and pump efficiency curve
  • Culverts: Two-way water movement between regions under culvert-flow laws
  • Impervious surfaces: Interception of the rain and transferring the intercepted water into the drainage system based on the mapping files.

Pending tasks before merge:

  • Finalize the culvert model.
  • Add timeframe feature for all models
  • Tests all model components on real domain for performance testing.
  • Create regression tests and documentation

saubhagya-gatech and others added 13 commits October 17, 2024 11:40
@saubhagya-gatech @ecoon
WIP gate evaluator files
989258e 
wip

fixes to the evaluator

first-cut running evaluator

checking water demand and supply

pending pump commits

added pump trigger and related  parameters

detention pond now referred to as storage area

cleanup
@ecoon
moves pump_on flag into state -- must check if this is initialized or…
fe1b45e 
… not (if not, add to input spec) and make sure it works if the pump is on at checkpoint/restart time
@ecoon
adds new evaluator for impervious interception
ff6f9ca
@dasvyat @ecoon
Added capability to output mesh cell centers
917d648
@dasvyat @ecoon
Moved the location of mesh info parameter list
0927570
@saubhagya-gatech @ecoon
reveresed last commit by Daniil to get domain info files
139db9f
@saubhagya-gatech @ecoon
works for single core, still need to debug imorter for parallel, adde…
03f63ad 
…d internal water balance check, fixed MultiplyReciprocal
@ecoon
fixes bugs in creation of gather to collect fluxes
fe29504
@saubhagya-gatech @ecoon
cleanup, water balance check, safety nets for improper parameter inputs
458a2fd
@saubhagya-gatech @ecoon
documentation for the pump system, water demand down-regulation based…
606cb6d 
… on the availability.
@saubhagya-gatech @ecoon
minor updates
fa3780a 
- currently downregulation is excluded. It is not needed if the PEC is choses carefully.
- some debug code is still kept in. It will be removed just before the merge.
@saubhagya-gatech @ecoon
minor updates to gates
b66c49e
@ecoon
adds limit to max flow rate through drainage network
775a6c9
@ecoon ecoon force-pushed the ssr/gates_and_pump branch from 82a687c to 775a6c9 Compare October 17, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saubhagya-gatech @ecoon @dasvyat