- Reduced dependencies, now release includes sources jar #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd chat behavior.
mliao95
reviewed
Jan 17, 2025
| @@ -54,50 +46,6 @@ class CommonUtils { | |||
| return rememberUpdatedState(isImeVisible) | |||
| } | |||
|
|
|||
| @Composable | |||
| fun MarkdownText(text: String, color: Color) { | |||
There was a problem hiding this comment.
Why can we remove this now?
There was a problem hiding this comment.
It was an old piece of code. We ported it to examples.
mliao95
approved these changes
Jan 17, 2025
agarwhi
approved these changes
Jan 17, 2025
Comment on lines
+109
to
+110
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Description:
What are the changes? Why are we making them?
Functional backward compatibility:
Does this change introduce backwards incompatible changes? [YES/NO]
Does this change introduce any new dependency? [YES/NO]
Testing:
Is the code unit tested?
Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?
List manual testing steps:
Here are a list of manual test cases to run through: