Fix mechanism for getting package version, when git is not present #349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
Not too long ago an API was added in order to provide access to ion-c version information programmatically. During the build, a cmake script would query git for detailed information (revision sha, commits since tag, etc) to include in the API's data.
In the event that git is not available, or not enough git commits have been pulled down (clone --depth 1 for instance) this information is not present. The intention, was to lean on the cmake project's version in this case, but 2 issues prevented that from happening, which this PR fixes.
CMAKE_PROJECT_VERSION
in a script that is not really executed as part of the project. This leads to an undefined version when git did not provide a version.This PR passes the project version to the cmake script as a define, so that it is always present. It also fixes the default version to include filler that would normally be present in a
git describe
, so that the regex correctly matches and version header is generated.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.