Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Amazon Linux version(s) used in Build & Test workflow #357

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

nirosys
Copy link
Contributor

@nirosys nirosys commented Jan 10, 2025

Issue #, if available: #346

Description of changes:
Recently Github bumped up the minimum version of Node that could be used for github actions to Node 20. This change had the side effect of also bumping up the minimum supported version of glibc for actions to 2.27.

Prior to this PR, we used both Amazon Linux 1 and 2 for our build and test workflow. Unfortunately, AM1 uses glibc 2.17, and AM2 uses glibc 2.26.

Amazon Linux 1 was EOL'd Dec 31, 2023, and stopped receiving security updates Jan 1, 2024. After multiple extensions, Amazon Linux will be EOL'd June 30, 2026. Amazon's recommendation is to use Amazon Linux 2023, which will have full support until 2028.

This PR removes both Amazon Linux 1 and 2, and adds 2023 in their place. Once AL 2025 is available, we should add that as well.

In addition, this PR also cleans up the GHA job by fixing some actionlint warnings, which includes updating to checkout v4.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nirosys nirosys marked this pull request as ready for review January 10, 2025 23:52
Copy link
Contributor

@jobarr-amzn jobarr-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also catching/cleaning the cmake3 linking logic :)

@jobarr-amzn jobarr-amzn merged commit fe5a984 into amazon-ion:master Jan 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants