Updates explanation of modules #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
reviewed
Nov 26, 2024
| For an inner module, it also includes the modules previously made available by the enclosing | ||
| module (via `import` or `module`). | ||
| * The macro table and symbol table are empty. | ||
| Before any clauses of the module definition are examined, each of these is empty. |
There was a problem hiding this comment.
The modules bindings does not contain $ion or _?
There was a problem hiding this comment.
That's correct. The bindings for $ion and _ are at the stream level. Referencing them inside a module will result in recursive lookups through the parent scopes until it reaches the stream. (Optimizations are possible, of course, but this is the behavior that must be achieved.)
tgregg
approved these changes
Nov 27, 2024
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the singular 'encoding module' model with the new 'encoding module sequence' design. It does not update all of the many examples in the spec that use the old model. I will put together a follow-on PR that addresses those (more mechanical) substitutions.
It also updates some of the text in the "What's New" section to reflect recent developments.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.