Fix for malformed utf8 sequence #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgregg
reviewed
Jan 13, 2020
| _streamReader = new StreamReader(inputStream, encoding); | ||
| _unreadStack = new Stack<int>(); | ||
| remainingChars = inputStream.Length; |
There was a problem hiding this comment.
It seems like not all implementations of Stream will support Length: https://docs.microsoft.com/en-us/dotnet/api/system.io.stream.length?view=netframework-4.8#System_IO_Stream_Length
Is there a way to implement this fix without using Stream.Length?
There was a problem hiding this comment.
Update the pull request as we discussed.
If an implementation does not support Length property, there won't be any check for short sequences.
Created issue #101 to keep track of this.
added 9 commits
March 30, 2020 13:56
R-maan
force-pushed
the
Fix-Short_UTF8-Sequence
branch
from
2d691d2 to
145a38b
Compare
tgregg
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #36 :
Description of changes:
If
StreamReader.Read()returns -1 while the stream still has bytes, an exception will be thrown as the stream cannot be parsed as a valid stream,