Skip to content

Commit

Permalink
Add support for binary 1.1 reader (#737)
Browse files Browse the repository at this point in the history
* Wire-up base 1.1 binary reader, and add null.null, and IVM support

* Remove debug prints, and apply cargo fmt

* Fix value lengths

* Add import; missed while branching for PRs

* Fixed warnings; unused imports and such

* Remove dead code

* Removing more dead code

* Fix copy-pasta'd error; macros not yet implemented, not unsupported

* Remove changes to Never; ultimately unused

* Remove unneeded constants and fix is_null

* Address clippy checks

* Address rustdoc issues

* Remove unneeded lifetime

* Address PR feedback

* Replace unimplemented macros with todo

* Fix rust doc

* Apply suggestions from code review

Co-authored-by: Zack Slayton <[email protected]>

---------

Co-authored-by: Zack Slayton <[email protected]>
  • Loading branch information
nirosys and zslayton authored Apr 16, 2024
1 parent c34ec54 commit 8b06c6f
Show file tree
Hide file tree
Showing 25 changed files with 1,815 additions and 162 deletions.
2 changes: 1 addition & 1 deletion examples/lazy_read_all_values.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ mod lazy_reader_example {

use memmap::MmapOptions;

use ion_rs::lazy::r#struct::LazyBinaryStruct;
use ion_rs::lazy::r#struct::LazyBinaryStruct_1_0 as LazyBinaryStruct;
use ion_rs::lazy::reader::LazyBinaryReader;
use ion_rs::lazy::value::LazyBinaryValue;
use ion_rs::lazy::value_ref::ValueRef;
Expand Down
5 changes: 5 additions & 0 deletions src/binary/constants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,8 @@ pub mod v1_0 {
pub const VAR_UINT: u8 = 14;
}
}

pub mod v1_1 {
/// Ion Version Marker byte sequence
pub const IVM: [u8; 4] = [0xE0, 0x01, 0x01, 0xEA];
}
Loading

0 comments on commit 8b06c6f

Please sign in to comment.