Don't Reset next_occurrence For Cloned Objects #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce so that cloned objects will not be treated as new and have their next_occurrence reset to the first date in the series. Expanded clone_with_day_offset to copy of the source object's next_occurrence, with offset, so that cloned object will not have to processed stale next_occurrence dates to 'catch up'. Added test to flex.
monroeclinton
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
I think this should be okay for coaching and goals, but I wonder about A-Team @somewes.
|
it is going to take me a minute to refresh myself on why some of this behaves the way it does and whether or not that will be a problem |
|
i can't think of anywhere we are duplicating an rrule, and i don't see any rrule duplicate code in our domain. if there is any logic specific to testing duplicated rrules, ideally we will have some tests to catch that in the actual app. you can always publish this (or a beta version) and run tests on the main project just to double check nothing fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clones via
clone_with_day_offsethave anext_occurrenceof the source object's first date +/- the offset. This requires these clones to be immediately handled and ignored untilnext_occurrenceis greater than now.These changes amend the logic determining if object is new by considering
last_occurrenceso that these cloned objects will not be treated as new and have theirnext_occurrencereset to the first date in the series.clone_with_day_offsethas been expanded to copy of the source object'snext_occurrence, with offset, so that cloned object will not have to processed stalenext_occurrencedates to 'catch up'. Added test to flex.