Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Prevent the regex filter from returning an object instead of a boolean
re.match return an object if match, None else
Demonstration
In this case, K.match() return a re.match() object instead of a boolean:
Tests also broken. False positive here, object is not None so you got True:
This fix include a little class helper that shortcuts
self.assertIs(exp, true)
toself.assertIsTrue(exp)
following your conventions. Tests are also updated with assertions helpers that follows Python AssertIs recommendations for booleans strict checking.Fix
Changed this line:
By this line:
is not None
explicit convert re.match() to boolean as K.match() should work.