refactor(wallet-connect): improve session management and validation #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `useConnectionsController` to utilize `AppState` for managing active sessions based on app focus, enhancing session handling. - Refactored `validateAndFilterSessions` to use `SessionTypes.Struct` for improved type safety and validation logic, ensuring robust session management.
- Removed the `SessionDeleteEvent` type and streamlined the `onSessionDelete` callback to directly close all modals and update active sessions using `walletKit.getActiveSessions()`, enhancing code clarity and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useConnectionsControllerto utilizeAppStatefor managing active sessions based on app focus, enhancing session handling.validateAndFilterSessionsto useSessionTypes.Structfor improved type safety and validation logic, ensuring robust session management.