fix(swap): enhance swap functionality with new payable arguments #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `swapPayableArgsCallback` to streamline argument preparation for ETH swaps. - Updated `swapExactETHForTokens`, `swapMultiHopExactTokensForTokens`, and `swapExactTokensForETH` functions to utilize the new callback for cleaner code and improved readability. - Modified `useSwapActions` hook to pass the correct amount parameters for token swaps, ensuring accurate transaction execution.
EvgeniyJB
approved these changes
Jan 17, 2025
… functions - Removed `swapArgsCallback` and `swapPayableArgsCallback` functions to streamline the codebase. - Updated imports in `index.ts` to reflect the removal of the deprecated functions. - This change enhances code readability and maintainability by consolidating argument preparation logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swapPayableArgsCallbackto streamline argument preparation for ETH swaps.swapExactETHForTokens,swapMultiHopExactTokensForTokens, andswapExactTokensForETHfunctions to utilize the new callback for cleaner code and improved readability.useSwapActionshook to pass the correct amount parameters for token swaps, ensuring accurate transaction execution.