Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(barcode-scanner): adjust ScanSquare height based on screen size #990

Merged
merged 1 commit into from
Jan 20, 2025
Merged

refactor(barcode-scanner): adjust ScanSquare height based on screen size #990

merged 1 commit into from
Jan 20, 2025
+23 −7

Conversation

ArturHoncharuk
Copy link
Collaborator

  • Updated the BarcodeScanner component to dynamically set the height of the ScanSquare based on screen size using the isSmallScreen utility.
  • Refactored ScanSquare to accept a height prop, improving flexibility and responsiveness.
  • Modified useBarcodeScanner hook to replace margin with padding for better layout control.

@ArturHoncharuk
refactor(barcode-scanner): adjust ScanSquare height based on screen size
7c167d1 
- Updated the BarcodeScanner component to dynamically set the height of the ScanSquare based on screen size using the isSmallScreen utility.
- Refactored ScanSquare to accept a height prop, improving flexibility and responsiveness.
- Modified useBarcodeScanner hook to replace margin with padding for better layout control.
@ArturHoncharuk ArturHoncharuk merged commit 7cf788f into dev Jan 20, 2025
2 checks passed
@ArturHoncharuk ArturHoncharuk deleted the AMB-5307 branch January 20, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvgeniyJB EvgeniyJB EvgeniyJB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArturHoncharuk @EvgeniyJB