refactor(swap): enhance swap execution handling and UI responsiveness #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `isExecutingPrice` state to manage the execution status of price calculations during swaps. - Updated `ReviewSwapButton` to disable the button when a price execution is in progress. - Modified `useSwapFieldsHandler` to set `isExecutingPrice` during token amount calculations, ensuring UI reflects loading states accurately. - Refactored swap function calls to wrap native addresses for improved compatibility. - Changed mock address in `BarcodeScanner` for better alignment with wallet connect standards.
…handling - Added `isExecutingPrice` to the swap context to manage the execution status during price calculations. - Updated the `Balance` component to disable the "Select Max" button when a price execution is in progress, enhancing user experience and preventing unintended actions during loading states.
EvgeniyJB
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isExecutingPricestate to manage the execution status of price calculations during swaps.ReviewSwapButtonto disable the button when a price execution is in progress.useSwapFieldsHandlerto setisExecutingPriceduring token amount calculations, ensuring UI reflects loading states accurately.BarcodeScannerfor better alignment with wallet connect standards.