Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ament_clang_tidy - Fix Reporting when WarningsAsErrors is specified in config #397

Merged
merged 3 commits into from
Apr 30, 2024
Merged

ament_clang_tidy - Fix Reporting when WarningsAsErrors is specified in config #397

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d977844
feature
mwcondino Jul 26, 2022
6a8f9b3
revert diff
mwcondino Jul 26, 2022
9cbb36e
fix typos
mwcondino Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ament_clang_tidy/ament_clang_tidy/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@ def start_subprocess(full_cmd):
print('The invocation of "%s" failed with error code %d: %s' %
(os.path.basename(clang_tidy_bin), e.returncode, e),
file=sys.stderr)
# Attempt to recover output, if any was found (eg - if
# WarningsAsErrors was specified in the config file).
output = e.output.decode('utf-8')
return output

files = []
Expand Down