Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove deprecated proposal plugin in favor of standardized plugin #61

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: remove deprecated proposal plugin in favor of standardized plugin #61

merged 1 commit into from
Jan 16, 2024

Conversation

10xLaCroixDrinker
Copy link
Member

Description

Replaced @babel/plugin-proposal-optional-chaining with @babel/plugin-transform-optional-chaining

Motivation and Context

Resolves the following warning on preset install:

npm WARN deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.

How Has This Been Tested?

Updated unit tests

  1. npm pack
  2. installed in another project that uses babel-preset-amex
  3. validated warning is no longer shown
  4. validated build still succeeds using optional chaining

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using babel-preset-amex?

no warnings on install

@10xLaCroixDrinker 10xLaCroixDrinker requested review from a team as code owners January 16, 2024 19:56
@smackfu smackfu requested a review from a team January 16, 2024 19:58
@10xLaCroixDrinker 10xLaCroixDrinker merged commit d1b476b into main Jan 16, 2024
3 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/remove-deprecated-plugin branch January 16, 2024 20:06
oneamexbot added a commit that referenced this pull request Jan 16, 2024
@oneamexbot
chore(release): 4.0.3 [skip ci]
a25167e 
## [4.0.3](v4.0.2...v4.0.3) (2024-01-16)

### Bug Fixes

* remove deprecated proposal plugin in favor of standardized plugin ([#61](#61)) ([d1b476b](d1b476b))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 4.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogpatch626 dogpatch626 dogpatch626 approved these changes

@smackfu smackfu smackfu approved these changes

Assignees
No one assigned
Labels
one-app-team-review-requested released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@10xLaCroixDrinker @oneamexbot @smackfu @dogpatch626