Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

fix(build): babel cli/config version conflict caused build failure #50

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix(build): babel cli/config version conflict caused build failure #50

merged 1 commit into from
Jan 18, 2024

Conversation

10xLaCroixDrinker
Copy link
Member

Description

Updated babel & babel config, replaced rimraf with del

Motivation and Context

Resolves this failure

Error: Requires Babel "^7.0.0-0", but was loaded with "6.26.3". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading the wrong version. Inspect the stack trace of this error to look for the first entry that doesn't mention "@babel/core" or "babel-core" to see what is calling Babel. (While processing preset: "~/git/env-config-utils/node_modules/babel-preset-amex/index.js")

Also fixed an issue where the npm run clean script was deleting the commitlint config

How Has This Been Tested?

Ran build and validated success. Rand clean and validated that build was delted and commitlint was not.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using env-config-utils?

N/A

@10xLaCroixDrinker 10xLaCroixDrinker requested review from a team as code owners January 17, 2024 21:30
Matthew-Mallimo
Matthew-Mallimo reviewed Jan 17, 2024
View reviewed changes
package.json
@@ -4,7 +4,7 @@
"description": "Utilities for runtime configuration validations",
"main": "index.js",
"scripts": {
"clean": "rimraf *.js",
"clean": "del *.js !*.config.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why replace rimraf?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it doesn't have an option to choose all the JS files except the config

@10xLaCroixDrinker 10xLaCroixDrinker merged commit c1660a7 into main Jan 18, 2024
4 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the bugfix/build-failure branch January 18, 2024 15:23
oneamexbot added a commit that referenced this pull request Jan 18, 2024
@oneamexbot
chore(release): 2.0.3 [skip ci]
82cb1e9 
## [2.0.3](v2.0.2...v2.0.3) (2024-01-18)

### Bug Fixes

* **build:** babel cli/config version conflict caused build failure ([#50](#50)) ([c1660a7](c1660a7))
* **preprocessEnvVar:** undefined env vars would be set to string ([#46](#46)) ([55d12a7](55d12a7))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 2.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Matthew-Mallimo Matthew-Mallimo Matthew-Mallimo left review comments

@bishnubista bishnubista bishnubista approved these changes

@dogpatch626 dogpatch626 dogpatch626 approved these changes

Assignees
No one assigned
Labels
one-app-team-review-requested released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@10xLaCroixDrinker @oneamexbot @Matthew-Mallimo @dogpatch626 @bishnubista