This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
feat(GraphQLProperty): support applying variables in the property annotation #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 23
💛 - Coveralls |
|
@jeremygiberson please review if you have a chance |
| @@ -25,4 +25,5 @@ | |||
|
|
|||
| String name(); | |||
| GraphQLArgument[] arguments() default {}; | |||
| GraphQLVariable[] variables() default {}; | |||
There was a problem hiding this comment.
Because variables are now definable w/ @GraphQLProperty -- they are definable at class level now through GraphQLProperty only. Do you want to update @GraphQLVariable(s) annotation to class level as well?
There was a problem hiding this comment.
Yep! I was going to add it here first and then another PR for both the GraphQLArgument and GraphQLVariable to be definable at the class level.
Just wanted to make this PR first for all the logic to handle a class level definition of it
|
Hello there! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some changes discussed as a part of #16