This repository has been archived by the owner on May 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PixnBits
reviewed
Sep 22, 2023
Converted to draft until one-app bundler updated |
code-forger
force-pushed
the
v7.0.0-alpha-webpack-5
branch
from
October 19, 2023 10:19
f19f462
to
da67ea2
Compare
code-forger
commented
Oct 24, 2023
packages/one-app-server-bundler/__tests__/utils/patchedCryptoHash.spec.js
Outdated
Show resolved
Hide resolved
remove crypto hash patch fro webpack 5 Move from eslint-loader to eslint-plugin
code-forger
force-pushed
the
v7.0.0-alpha-webpack-5
branch
from
February 1, 2024 16:57
5b8482d
to
23fa890
Compare
packages/one-app-bundler/webpack/loaders/validate-required-externals-loader.js
Outdated
Show resolved
Hide resolved
Matthew-Mallimo
previously approved these changes
Feb 2, 2024
guym4c
previously approved these changes
Feb 7, 2024
packages/one-app-bundler/webpack/loaders/provided-externals-loader.js
Outdated
Show resolved
Hide resolved
code-forger
dismissed stale reviews from guym4c and Matthew-Mallimo
via
February 8, 2024 12:43
64c72bd
guym4c
previously approved these changes
Feb 8, 2024
Matthew-Mallimo
previously approved these changes
Feb 8, 2024
JAdshead
reviewed
Feb 8, 2024
packages/one-app-server-bundler/__tests__/utils/getConfigOptions.spec.js
Outdated
Show resolved
Hide resolved
code-forger
dismissed stale reviews from Matthew-Mallimo and guym4c
via
February 9, 2024 11:20
21441b5
guym4c
approved these changes
Feb 9, 2024
Matthew-Mallimo
approved these changes
Feb 9, 2024
Matthew-Mallimo
approved these changes
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move to webpack 5
Motivation
Webpack 4 is no longer supported
Test Conditions
Used to build a module locally
Types of changes
Check boxes that apply:
Checklist
Check boxes that apply: