Skip to content
This repository was archived by the owner on May 3, 2024. It is now read-only.

fix(devCdn): only cache 200's #1245

Merged
merged 6 commits into from
Feb 1, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/server/utils/devCdnFactory.js
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,14 @@ export const oneAppDevCdnFactory = ({
});
const { status, type } = remoteModuleResponse;
const responseText = await remoteModuleResponse.text();
cachedModuleFiles = removeExistingEntryIfConflicting(
incomingRequestPath,
cachedModuleFiles
);
cachedModuleFiles[incomingRequestPath] = responseText;
writeToCache(cachedModuleFiles);
if (status === 200) {
cachedModuleFiles = removeExistingEntryIfConflicting(
incomingRequestPath,
cachedModuleFiles
);
cachedModuleFiles[incomingRequestPath] = responseText;
writeToCache(cachedModuleFiles);
}
reply
.code(status)
.type(type)
Expand Down
Loading