GeNTooGeek patch change visibility before after update source text #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Searches for lyric sources in nested scenes. The recursive function defined mimics obs_scene_find_source_recursive, but also searches through scene sources in addition to sceneitem groups. Also uncomments a obs_source_release that shouldn't have been commented.
…scene Allow lyrics text in nested scenes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small modification to hide sources prior to update and then set to visible again afterward.
As I was playing around with the fading functionality, I noticed that the fading was not consistently timed. So I started looking into the code, and I began to wonder why the fading is implemented directly in the script, as opposed to relying on the transitions available during source visibility changes. I noticed that the existing code, when fading is not enabled, simply changes the text while the sources are visible. By hiding the sources prior to changing the text and then unhiding them after, we can take advantage of the show/hide transitions.
This does do some weird things when Transition Preview to program is enabled and I haven't really worked those out. My current project doesn't require that option and I won't have time to further troubleshoot until after it is completed, but I will look more into it. It will likely be a couple weeks before I can dedicate much time to this, again.