New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added optional parameter withing #106

Open

bboyle1234 wants to merge 3 commits into amis92:master from bboyle1234:OptionalParameterWithing

bboyle1234 commented Sep 20, 2019

bboyle1234 added 3 commits

September 20, 2019 07:24


          Added optional parameter withing

585ab73


          Improved comments

8070f31


          Made optional struct readonly and prevented defensive struct copying …

8a3cba5

…by making "in" method parameters

Owner

amis92 commented Sep 20, 2019

I'm glad you built this so quickly and easily, working simple code is the best code.

However:

Any new Feature should be first hidden behind a new Features flag.
Attributes namespace/package isn't the best place for embedding Optional. Also embedding is the last solution I'd like to go with. Let's keep discussing this in A different kind of Wither: With(Optional...) #102.
Making the Optional parameters in doesn't really help performance, I think. It's a small struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet