Skip to content

Commit

Permalink
Merge pull request #74 from dekallo/globals
Browse files Browse the repository at this point in the history
Don't leak globals, fix `/eh list`, create workflows
  • Loading branch information
amki authored Oct 19, 2024
2 parents c8d8b9a + e32778d commit cf593bd
Show file tree
Hide file tree
Showing 4 changed files with 172 additions and 114 deletions.
16 changes: 16 additions & 0 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Check Pull Request

on: [pull_request]

jobs:
test:
runs-on: ubuntu-latest

steps:
- name: Clone project
uses: actions/checkout@v4

- name: Run luacheck
uses: BigWigsMods/actions/luacheck@master
with:
args: -q
21 changes: 21 additions & 0 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Push

on:
push:
paths-ignore:
- '.github/**'
- '*.md'
workflow_dispatch:

jobs:
build:
runs-on: ubuntu-latest

steps:
- name: Clone project
uses: actions/checkout@v4

- name: Run luacheck
uses: BigWigsMods/actions/luacheck@master
with:
args: -q
28 changes: 28 additions & 0 deletions .luacheckrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
td = "lua51"
max_line_length = false
codes = true
ignore = {
"2",
"4"
}
globals = {
"C_ChatInfo",
"C_Spell",
"C_Timer",
"CombatLogGetCurrentEventInfo",
"CreateFrame",
"ElitismHelperDB",
"GetDefaultLanguage",
"GetRealmName",
"GetUnitName",
"IsInGroup",
"IsInRaid",
"Round",
"SendChatMessage",
"SlashCmdList",
"SLASH_ELITISMHELPER1",
"strsplit",
"UnitGroupRolesAssigned",
"UnitHealthMax",
"UnitIsPlayer"
}
Loading

0 comments on commit cf593bd

Please sign in to comment.