Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker-container-action with build-args #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yinchi
Copy link

@yinchi yinchi commented Sep 9, 2024

This implements my suggested change in #57. An ARG line is added to the Dockerfile to represent the Sphinx version. The action.yml file is edited to use Docker Container Action as GitHub's own offering lacks the required build-args feature.

A new input sphinx-tag is added, defaulting to "2.4.4" for compatibility with the current master behavior.

Note that the synchronize workflow should no longer be needed, nor the dozens of tags in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant