Fix sorting for days with cancelled scores

amochtar · Dec 8, 2020 · a4fe2dc · a4fe2dc
1 parent fe63d76
commit a4fe2dc
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/calculate.js b/src/calculate.js
@@ -47,7 +47,12 @@ function compareRankingByDay(day) {
 function compareTotalRankingByDay(day) {
     return function (a, b) {
         if (a.total_scores[day] === b.total_scores[day]) {
-            return +a.id - +b.id;
+            if (a.completed[day] === b.completed[day]) {
+                return +a.id - +b.id;
+            }
+            if (!a.completed[day]) return 1;
+            if (!b.completed[day]) return -1;
+            return a.completed[day] - b.completed[day];
         }
         return b.total_scores[day] - a.total_scores[day];
     };