Заменил LooseValidAt на ValidAt для обеспечения поддержки старых версий #586
+27
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bessudnov
reviewed
Jan 29, 2025
src/AmoCRM/OAuth/AmoCRMOAuth.php
Outdated
| @@ -32,7 +32,7 @@ | |||
| use Lcobucci\JWT\Validation\Constraint; | |||
| use Lcobucci\JWT\Validation\Constraint\PermittedFor; | |||
| use Lcobucci\JWT\Validation\Constraint\SignedWith; | |||
| use Lcobucci\JWT\Validation\Constraint\LooseValidAt; | |||
| use Lcobucci\JWT\Validation\Constraint\ValidAt; | |||
There was a problem hiding this comment.
а в новых версия либы не доступен ValidAt, сломаешь для тех, у кого новая версия
по идее тебе нужно проверять, если доступен LooseValidAt - использовать его, если нет - ValidAt
|
Добавлен метод для динамического выбора ValidAt или LooseValidAt (приоритет у LooseValidAt) Описание: |
bessudnov
reviewed
Jan 30, 2025
| @@ -673,4 +675,23 @@ private function getSharedApiDomain(AccessTokenInterface $accessToken): string | |||
|
|
|||
| return $apiDomain; | |||
| } | |||
| private function createValidAtConstraint(): object | |||
There was a problem hiding this comment.
нужен php док для метода
и по код-стайлу проверь, не пройдет кажется, методы должны быть разделены
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В рамках этого изменения было выполнено следующее:
Причина изменений:
Для обеспечения обратной совместимости с более старыми версиями библиотеки, где использовался класс ValidAt. Это необходимо для тех пользователей, которые не обновили свою библиотеку до последних версий.