Fix undefined server url error #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorimjj
requested changes
Nov 16, 2022
There was a problem hiding this comment.
Hey @precupstefan, thank you for your contribution, sorry for the delay... Just few comments for you.
| throw new NoServerError(); | ||
| if (!server) { | ||
| let baseUrl = ''; | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment |
There was a problem hiding this comment.
To keep the project consistent, the disables should be avoid. Can you fix that?
| if ( !server ) { | ||
| throw new NoServerError(); | ||
| if (!server) { | ||
| let baseUrl = ''; |
There was a problem hiding this comment.
It should be moved into another method
|
lgtm. keep it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.