250 frontend alert overview page matching alerts with previous same alerts and display history #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e' into 250-frontend-alert-overview-page-matching-alerts-with-previous-same-alerts-and-display-history
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
…e' into 250-frontend-alert-overview-page-matching-alerts-with-previous-same-alerts-and-display-history
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
…e' into 250-frontend-alert-overview-page-matching-alerts-with-previous-same-alerts-and-display-history
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
…rview-page-matching-alerts-with-previous-same-alerts-and-display-history
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: engelharddirk <[email protected]>
| " | ||
| class="is-solid" | ||
| ></cds-icon> | ||
| {{ summary.mostFrequentAlert.severity }} |
There was a problem hiding this comment.
Since the severity alert type inside the History is always the same, the severity also will always be the same. Just throwing the Thought in here, might be sensible to display it anyway.
|
|
||
| <div class="alert-meta" *ngIf="alert.taskId"> | ||
| <span> | ||
| <strong>Task ID:</strong> {{ alert.taskId }} |
There was a problem hiding this comment.
May be easier to follow if we used the task display name. I already informed you about my PR, maybe we can switch that out
…ckend add all remaining requested data from issue
Signed-off-by: Christoph Klingenberg <[email protected]>
engelharddirk
approved these changes
Jan 20, 2025
Signed-off-by: Christoph Klingenberg <[email protected]>
Signed-off-by: Christoph Klingenberg <[email protected]>
…rts-with-previous-same-alerts-and-display-history
chrisklg
deleted the
250-frontend-alert-overview-page-matching-alerts-with-previous-same-alerts-and-display-history
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
history to present same alerts