Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: MAN-1746 pass org via image-studio-sdk #52

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: MAN-1746 pass org via image-studio-sdk #52

wants to merge 7 commits into from

Conversation

simbobs
Copy link

@simbobs simbobs commented Nov 21, 2024 •
edited
Loading

  • bump to image-studio-sdk v0.5.1
    • pass org ID to image studio
    • update to make use of new event listener logic. Studio no longer closes on hitting save
  • update studio base url
  • rename installation param from imageStudioUrl -> imageStudioDomain

@simbobs simbobs requested review from Benj0s and bennealon December 19, 2024 15:56
@simbobs simbobs marked this pull request as ready for review January 6, 2025 14:55
amplience-dling
amplience-dling approved these changes Jan 8, 2025
View reviewed changes
Copy link

@amplience-dling amplience-dling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, most of the file affected are just formatting

rs-amp
rs-amp approved these changes Jan 8, 2025
View reviewed changes
src/app/image-studio/image-studio.service.ts Outdated Show resolved Hide resolved
@simbobs simbobs requested a review from bennealon January 13, 2025 14:07
@simbobs
build: angular config change
75fb67b 
update sdk imports
@simbobs simbobs requested a review from Benj0s January 24, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amplience-dling amplience-dling amplience-dling approved these changes

@h-czubrychowski h-czubrychowski h-czubrychowski approved these changes

@rs-amp rs-amp rs-amp approved these changes

@Benj0s Benj0s Benj0s approved these changes

@biggianteye biggianteye biggianteye approved these changes

@bennealon bennealon Awaiting requested review from bennealon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@simbobs @biggianteye @Benj0s @bennealon @rs-amp @h-czubrychowski @amplience-dling