Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TAR-237 Clicking add button works now #26

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

jonnyAmplience
Copy link
Collaborator

  • trimming keywords when we initially set the value
  • showing cursor:pointer when hovering the add button
  • passing the updated value to the onChange event instead of the previous value

- trimming keywords when we initially set the value
- showing cursor:pointer when hovering the add button
- passing the updated value to the onChange event instead of the previous value
Copy link

github-actions bot commented Apr 15, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 99.46% 2416/2429
🟢 Branches 96.3% 208/216
🟢 Functions 98.97% 96/97
🟢 Lines 99.46% 2416/2429
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / getTitle.ts
100%
50% (-50% 🔻)
100% 100%

Test suite run success

149 tests passing in 43 suites.

Report generated by 🧪jest coverage report action from 3380562

@osharaan osharaan requested a review from Chattox April 18, 2024 16:23
@jonnyAmplience jonnyAmplience merged commit 01b3f08 into main Apr 19, 2024
3 checks passed
@jonnyAmplience jonnyAmplience deleted the bug.TAR-237-manual-creation branch April 19, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants