Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed FP fix_except where the presence of comma was not explicity che… #38

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed FP fix_except where the presence of comma was not explicity che… #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59c854c
Fixed FP fix_except where the presence of comma was not explicity che…
sole6 Mar 15, 2021
f922f5a
Improved comma check
sole6 Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .idea/vcs.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions fissix/fixes/fix_except.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@ def transform(self, node, results):
for except_clause, e_suite in find_excepts(try_cleanup):
if len(except_clause.children) == 4:
(E, comma, N) = except_clause.children[1:4]
comma.replace(Name("as", prefix=" "))
changed = True
if ',' in comma.value:
comma.replace(Name("as", prefix=" "))
changed = True

if N.type != token.NAME:
# Generate a new N for the except clause
Expand Down
Empty file added fissix/tests/data/fixers/fixer_except.py
View file
Open in desktop
Empty file.