-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
5b38287
commit 5d5c6a4
Showing
5 changed files
with
433 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
2 comments
on commit 5d5c6a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @akshitaWaldia
it actually should be BC breaks release as now developers need to implement new methods for the public interface Amazon/Pay/API/ClientInterface.php
. Or the package doesn't use SemVer 2.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @akshitaWaldia
it actually should be BC breaks release as now developers need to implement new methods for the public interface
Amazon/Pay/API/ClientInterface.php
. Or the package doesn't use SemVer 2.0?
Yes, it makes sense. We are changing this
@akshitaWaldia
BTW:
Doc block from interfaces allows passing a string as the first param:
But
\Amazon\Pay\API\Client::apiCall
doesn't support$queryParams
of string type:amazon-pay-api-sdk-php/Amazon/Pay/API/Client.php
Lines 483 to 491 in 5d5c6a4