Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

Commit

Permalink
windows: Fix debug category linkage
Browse files Browse the repository at this point in the history
Fixes this linker error:

libmultipartuploader.a(gsts3multipartuploader.cpp.obj) : error LNK2001: unresolved external symbol "struct _GstDebugCategory * gst_s3_sink_debug" (?gst_s3_sink_debug@@3PEAU_GstDebugCategory@@ea)
src/gsts3elements.dll : fatal error LNK1120: 1 unresolved externals

Essentially, the debug category is a C symbol, so put it inside
G_BEGIN_DECLS so that it doesn't get C++ symbol mangling.
  • Loading branch information
nirbheek authored and loganek committed Jan 21, 2022
1 parent 8aa7cde commit b4de729
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/gsts3multipartuploader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@

#include <gst/gst.h>

GST_DEBUG_CATEGORY_EXTERN(gst_s3_sink_debug);

namespace gst
{
namespace aws
Expand Down
2 changes: 2 additions & 0 deletions src/gsts3multipartuploader.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

G_BEGIN_DECLS

GST_DEBUG_CATEGORY_EXTERN(gst_s3_sink_debug);

typedef struct _GstS3MultipartUploader GstS3MultipartUploader;

GstS3Uploader * gst_s3_multipart_uploader_new (const GstS3UploaderConfig * config);
Expand Down

0 comments on commit b4de729

Please sign in to comment.