Compatible with Terraform's Name best practices #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? The current code automatically generates very long resource names. Terraform best practices recommend not repeating resource types in resource names. This change excludes the resource type from the resource name as well to generates very simple resource names. refs: https://www.terraform-best-practices.com/naming#resource-and-data-source-arguments
delete-merged-branch
bot
deleted the
compatible_with_terraform_bestpractice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for making this tool!
It looks like it will be easy and successful to Upgrade AWS Provider.
I would like to suggest a few improvements.
This is a proposal. The Code owner is free to change this PR at will.
Why?
The current code automatically generates very long resource names. Terraform best practices recommend not repeating resource types in resource names.
This change excludes the resource type from the resource name as well to generates very simple resource names.
refs: https://www.terraform-best-practices.com/naming#resource-and-data-source-arguments