Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] CI and packaging #5

Merged
merged 19 commits into from
Nov 18, 2024
Merged

[chore] CI and packaging #5

merged 19 commits into from
Nov 18, 2024

Conversation

AlbertDeFusco
Copy link
Collaborator

  • drop tag prefix for versioning
  • add github action to test and build

mattkram
mattkram reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@mattkram mattkram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A few comments about workflow, so let's discuss those before approval, but it LGTM.

Once we decide the workflow name I'll figure out how to get PyPI publishing working again.

This was referenced Nov 12, 2024
Open
Open
Closed
mattkram
mattkram approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@mattkram mattkram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more tiny name changes, but looks great!

Let's defer the PyPI upload changes into its own PR so we have CI/CD going.

AlbertDeFusco and others added 3 commits November 18, 2024 11:38
@AlbertDeFusco AlbertDeFusco added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 14cc057 Nov 18, 2024
8 checks passed
@mattkram mattkram deleted the chore/ci-and-pkg branch February 5, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkram mattkram mattkram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlbertDeFusco @mattkram