projects/ad719x_asdz/coraz7s: Add make parameter & SYNCN on GPIO 33. Update documentation #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IuliaCMoldovan
force-pushed
the
dev_ad719x
branch
from
fb64cbc
to
641f0cb
Compare
IuliaCMoldovan
force-pushed
the
dev_ad719x
branch
2 times, most recently
from
62544c4
to
94f68a1
Compare
sarpadi
reviewed
Nov 12, 2024
| input adc_spi_miso_rdyn, | ||
| output adc_spi_mosi, | ||
| output adc_spi_csn, | ||
| output adc_syncn |
There was a problem hiding this comment.
my recommendation is that sync should be considered a bidirectional pin driven by the ad_iobuf module. software can control it the way it needs to be controlled
There was a problem hiding this comment.
The software, in the current stage, doesn't "know" how to control it
There was a problem hiding this comment.
In the data sheet it states that it is an input for the chip (thus output from the FPGA) so why should it be made inout?
Did the change with ad_iobuf and removed the hardcoding
IuliaCMoldovan
force-pushed
the
dev_ad719x
branch
3 times, most recently
from
0715e92
to
455b30d
Compare
* Made the project parameterizable through ARDZ_PMOD_N parameter * Added possibility to connect through the Arduino header as well * Separated the top file and the constraints, for Arduino header & for PMOD JA * Added GPIO 33 - SYNCN, for the Arduino header connection mode * Added logging of make parameter in sysid string Signed-off-by: Iulia Moldovan <[email protected]>
IuliaCMoldovan
force-pushed
the
dev_ad719x
branch
from
455b30d
to
eab67d4
Compare
IuliaCMoldovan
requested review from
gastmaier,
StancaPop,
LBFFilho,
cristianmihaipopa,
acostina,
AndreiGrozav and
PopPaul2021
as code owners
* Added GPIO section as it was missing * Added details on using the make parameter ARDZ_PMOD_N as well as separate build commands depending on the carrier * Removed the diagram from Software considerations as it didn't make sense, since the evaluation board which doesn't have PMOD connector will be placed on top of Cora to use the Arduino header, and not connected through wires * Added links to Linux and no-OS files Signed-off-by: Iulia Moldovan <[email protected]>
Signed-off-by: Iulia Moldovan <[email protected]>
IuliaCMoldovan
force-pushed
the
dev_ad719x
branch
from
769c0b4
to
5b8ed0c
Compare
|
Fixed conflicts from the merging of the DE10-Nano project, updated the documentation to contain sections for both Cora and DE10-Nano and updated the CODEOWNERS file. |
sarpadi
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The software is in PR analogdevicesinc/linux#2554
PR Type
PR Checklist