Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ad3530r driver #2680

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add ad3530r driver #2680

wants to merge 4 commits into from
+756 −1

Conversation

kseerp
Copy link
Contributor

@kseerp kseerp commented Dec 17, 2024 •
edited
Loading

PR Description

Part is unreleased, allowed by requestor to create PR for public release and initial review.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

@kseerp kseerp marked this pull request as draft December 17, 2024 10:39
@kseerp kseerp force-pushed the dev/ad353xr branch 4 times, most recently from de62301 to fc99356 Compare December 20, 2024 15:40
@kseerp
Copy link
Contributor Author

kseerp commented Dec 20, 2024

v2

  • address relevant CI complaints

@kseerp kseerp marked this pull request as ready for review December 20, 2024 15:46
nunojsa
nunojsa reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round...

drivers/iio/dac/ad3530r.c Outdated Show resolved Hide resolved
drivers/iio/dac/ad3530r.c Show resolved Hide resolved
drivers/iio/dac/ad3530r.c Show resolved Hide resolved
drivers/iio/dac/ad3530r.c Outdated Show resolved Hide resolved
drivers/iio/dac/ad3530r.c Outdated Show resolved Hide resolved
drivers/iio/dac/ad3530r.c Outdated Show resolved Hide resolved
drivers/iio/dac/ad3530r.c Outdated Show resolved Hide resolved
drivers/iio/dac/ad3530r.c Outdated Show resolved Hide resolved
drivers/iio/dac/ad3530r.c Show resolved Hide resolved
drivers/iio/dac/ad3530r.c Outdated Show resolved Hide resolved
@kseerp kseerp closed this Jan 31, 2025
kseerp added 4 commits January 31, 2025 15:27
@kseerp
iio: dac: ad3530r: Add ABI file for the AD3530R DAC
e2cd619 
Define muxout_select and muxout_select_available sysfs interface for the
AD3530R DAC.

Signed-off-by: Kim Seer Paller <[email protected]>
@kseerp
dt-bindings: iio: dac: Add adi,ad3530r.yaml
b7ff9cb 
Add documentation for ad3530r.

Signed-off-by: Kim Seer Paller <[email protected]>
@kseerp
iio: dac: ad3530r: Add driver for AD3530R
1bbb606 
The AD3530/AD3530R are low power, 8-channel, 16-bit, buffered voltage
output, DACs that include software-programmable gain controls that
result in full-scale output spans of 2.5V or 5V for reference voltages
of 2.5V. The devices operate from single, 2.7V to 5.5V supply ranges and
are guaranteed monotonic by design. The AD3530R also offers a 2.5V,
5ppm/°C internal reference that is disabled by default.

Signed-off-by: Kim Seer Paller <[email protected]>
@kseerp
iio: Kconfig.adi: imply AD3530R
fba794c 
Add entry for the AD3530R driver.

Signed-off-by: Kim Seer Paller <[email protected]>
@kseerp kseerp reopened this Jan 31, 2025
@kseerp
Copy link
Contributor Author

kseerp commented Jan 31, 2025

v3

  • added ABI file

bindings:

  • added iovcc-supply property
  • made vcc-supply and iovcc-supply as required property
  • added datasheet link

ad3530r:

  • dropped unused macros, headers and registers
  • used devm_regulator_get_enable_read_voltage()
  • used IIO_DMA_MINALIGN macro for alignment
  • used macros for hardcoded values
  • modified state for reset-gpio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunojsa nunojsa nunojsa left review comments

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@btogorean btogorean Awaiting requested review from btogorean btogorean is a code owner

@chegbeli chegbeli Awaiting requested review from chegbeli chegbeli is a code owner

@buha buha Awaiting requested review from buha buha is a code owner

@amiclaus amiclaus Awaiting requested review from amiclaus amiclaus is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

@CiprianRegus CiprianRegus Awaiting requested review from CiprianRegus CiprianRegus is a code owner

@machschmitt machschmitt Awaiting requested review from machschmitt machschmitt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kseerp @nunojsa