ci(workflow): Update Zephyr-HAL workflow #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script removes 'msdk_sha' file from 'hal_adi' repository. This causes creating a commit to 'hal_adi' for not related PRs. Solved this problem with this commit. Signed-off-by: Furkan Akkiz <[email protected]>
With this change, hal_adi commits will have same description and author information with MSDK commits. Also it does not try to send a commit if there was no change. Signed-off-by: Furkan Akkiz <[email protected]>
sihyung-maxim
approved these changes
Jan 28, 2025
ttmut
approved these changes
Jan 29, 2025
|
Can you not add msdk_sha to hal_adi .gitignore instead? |
If we add "msdk_sha" file to hal_adi ".gitignore", we cannot add new MSDK commits' sha into this file. So, I think this way is fine. |
ttmut
approved these changes
Jan 30, 2025
|
@MaureenHelm can you take a look? |
MaureenHelm
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current workflow sends some commits which has only "msdk_sha" file change. To avoid these commits, I implemented a solution which protects "msdk_sha" file from remove operation.
Also, I updated workflow to send commits to "hal_adi" with same description and author information as MSDK commits.
Checklist Before Requesting Review