Skip to content

Commit

Permalink
do not run apt update or simulate apt dist-upgrade
Browse files Browse the repository at this point in the history
This is causing all sorts of problems. The first of which is that
we're hitting our poor mirrors every time the script is ran, which, in
the Debian package configuration, is *every 15 minutes* (!!).

The second is that this locks the cache and makes this script
needlessly stumble upon a possible regression in APT from Debian
bookworm and Ubuntu 22.06:

https://bugs.launchpad.net/ubuntu/+source/apt/+bug/2003851

That still has to be confirmed: it's possible that `apt update` can
hang for a long time, but that shouldn't concern us if we delegate
this work out of band.

I also do not believe actually performing the `dist-upgrade`
calculations is necessary to compute the pending upgrades at all. I've
done work with python-apt for other projects and haven't found that to
be required: the cache has the necessary information about pending
upgrades.

Closes: prometheus-community#179
  • Loading branch information
anarcat committed Oct 13, 2023
1 parent 34dd42e commit dc995a9
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions apt_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,6 @@ def _write_reboot_required(registry):
def _main():
cache = apt.cache.Cache()

# First of all, attempt to update the index. If we don't have permission
# to do so (or it fails for some reason), it's not the end of the world,
# we'll operate on the old index.
with contextlib.suppress(apt.cache.LockFailedException, apt.cache.FetchFailedException):
cache.update()

cache.open()
cache.upgrade(True)

registry = CollectorRegistry()
_write_pending_upgrades(registry, cache)
_write_held_upgrades(registry, cache)
Expand Down

0 comments on commit dc995a9

Please sign in to comment.