Fixed sampleRate settings to be adapted to Ios #61
Conversation
|
Hey, thank you for your work. I need a bit more time to look over the changes; I'll get back to you sometime this week. In the meantime, I'd like to ask you to please open an issue describing why you suggest this change. This helps me keep track of changes more easily. |
|
Thanks for the reply. |
There was a problem hiding this comment.
Alright, I've had a look through the changes. A general note upfront: If you leave out all the style changes to files unrelated to your actual issue, you significantly raise the chances of your changes being reviewed quickly.
That said, as also noted below, I will let those style changes pass because it doesn't really matter to me; there is one though I'd like you to change.
Afterwards, I can merge your changes. I cannot evaluate the actual iOS changes, and thus I will trust they work.
Option 1: Add new feature to the app Option 2: Fix issue with mic_stream not working properly Option 3: Improve performance of main.dart file Option 4: Update dependencies in pubspec.yaml Option 5: Reformat code in main.dart to adhere to style guide.
This commit adds .vscode to the .gitignore file, preventing it from being committed to the repository.
This commit removes the `.vscode/settings.json` file. The file was deleted and there is no longer a need for it in the project.
… conditions The commit message describes the changes made in the commit. In this case, the code has been simplified by removing unnecessary line breaks and if conditions. Therefore, the appropriate commit message would be "refactor: simplify code by removing unnecessary line breaks and if conditions".
| @@ -113,8 +113,7 @@ class _MicStreamExampleAppState extends State<MicStreamExampleApp> | |||
| } | |||
|
|
|||
| void _calculateSamples(samples) { | |||
| if (page == 0) | |||
| _calculateWaveSamples(samples); | |||
| if (page == 0) _calculateWaveSamples(samples); | |||
There was a problem hiding this comment.
Changed to one line!
|
Thanks for the review. |
|
Sadly, I don't have the time to set things like autoformattung up. At some point in the future I want to clean up the whole project, but until then, I can only give basic support |
|
I'll merge and publish it some time this week |
|
Published as |
|
Hey @yama-yeah - sorry for the late response - but I just tested this on the latest ios and it does not seems to work |
|
As shown here IOS does not guarantee a change in sampling rate. |
#62
Modified code so that SampleRate can be changed.
Since the ChangeLog has not been touched, please edit the ChangeLog if you want to incorporate this modification as a new version.