Allow configuring ui custom_message via chart #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holt
reviewed
Jan 16, 2025
| ## @param anchoreConfig.ui.custom_message.title A title key, whose string value provides a title for the message | ||
| ## @param anchoreConfig.ui.custom_message.message A message key, whose string value is the message itself | ||
| ## | ||
| custom_message: {} |
There was a problem hiding this comment.
Probably best to comment this line out while it's empty because I think our YAML validator will expect the keys to be provided if it's present.
There was a problem hiding this comment.
Mike, that's a good shout! I just tested it and if custom_message is empty nothing gets rendered in the config map which represents the config-ui.yaml.
Signed-off-by: Greg Nyahay <[email protected]>
gnyahay
force-pushed
the
add-ui-message
branch
from
8465555 to
77a0b1e
Compare
HN23
approved these changes
Jan 17, 2025
Btodhunter
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.