ensure unresolved go-proxy version does not check online (#9)

Signed-off-by: Alex Goodman <[email protected]>
anchore · Oct 2, 2023 · 0ccc593 · 0ccc593
1 parent 94438a5
commit 0ccc593
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/tool/goproxy/version_resolver.go b/tool/goproxy/version_resolver.go
@@ -38,7 +38,7 @@ func (v VersionResolver) ResolveVersion(want, _ string) (string, error) {
 		return want, nil
 	}
 
-	if want == latest {
+	if want == latest && !v.config.AllowUnresolvedVersion {
 		return v.findLatestVersion("")
 	}
 

diff --git a/tool/goproxy/version_resolver_test.go b/tool/goproxy/version_resolver_test.go
@@ -1,6 +1,7 @@
 package goproxy
 
 import (
+	"fmt"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -64,7 +65,7 @@ func TestVersionResolver_ResolveVersion(t *testing.T) {
 			version: "latest",
 			want:    "latest", // this is a pass through to go-install, which supports this as input
 			availableVersionsFetcher: func(url string) ([]string, error) {
-				return []string{""}, nil
+				return nil, fmt.Errorf("should never be called")
 			},
 		},
 	}