Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUP - Concepto Receta Autorización #3071

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RUP - Concepto Receta Autorización #3071

wants to merge 1 commit into from

Conversation

aldoEMatamala
Copy link
Contributor

@aldoEMatamala aldoEMatamala commented Sep 10, 2024 •
edited
Loading

Requerimiento

https://proyectos.andes.gob.ar/browse/RUP-415

Funcionalidad desarrollada

  1. Se restringe la agregación del concepto Receta en RUP a profesionales :
  • Médico/ Obstetra/ Odontólogo
  • Matricula Vigente (no vencida/ no suspendida/ matriculado)

UserStory llegó a completarse

  • Si
  • No
  • No corresponde

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

  • Si
  • No

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

@aldoEMatamala aldoEMatamala requested review from a team as code owners September 10, 2024 18:18
@aldoEMatamala aldoEMatamala force-pushed the RUP-415 branch 2 times, most recently from 758c84d to 79dfb10 Compare September 10, 2024 18:28
@MCele MCele requested a review from agustin1996ra September 20, 2024 12:32
MCele
MCele requested changes Sep 20, 2024
View reviewed changes
src/app/modules/rup/components/ejecucion/buscador.component.ts Outdated
let permiso = false;
if (concepto.conceptId === '16076005') {// receta
if (this.auth.profesional) {
this.profesionalService.get({ documento: this.auth.usuario.documento }).subscribe(profesional => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

la búsqueda por documento no siempre es conveniente en este caso, ya que si fuera un profesional duplicado puede no coinicidir el profesional vinculado al usuario con el primero profesional encontrado en la base, en este caso la búsqueda debería realizarse por el id del profesional vinculado al usuario. La sugerencia de cambio quedaría:

this.profesionalService.getByID(this.auth.profesional).subscribe(profesional => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corregido!

src/app/modules/rup/components/ejecucion/buscador.component.ts Outdated
if (profesional.length) {
const codigosPermitidos = [1, 2, 23]; // medico, odontologo, obstetra
let motivoRechazo = null;
permiso = (profesional[0].formacionGrado.find(item => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

falta un control en formacionGrado, porque puede ser null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corregido!

src/app/modules/rup/components/ejecucion/buscador.component.ts Show resolved Hide resolved
src/app/modules/rup/components/ejecucion/buscador.component.ts Outdated
@@ -414,6 +416,55 @@ export class BuscadorComponent implements OnInit, OnChanges {
*
* @param {any} concepto Concepto SNOMED
*/
public verificarProfesional(concepto, index) {
let permiso = false;
if (concepto.conceptId === '16076005') {// receta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aldito lo veo muy bien, te voy dejando detalles a mejorar que noté.
Acá veo que está perfecto el control por concepto, pero también controlar que no sea una solicitud

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
agregado! gracias por los comentarios cele!

@negro89 negro89 added the changes requested Se solicitaron cambios label Sep 23, 2024
@aldoEMatamala aldoEMatamala added changes done and removed changes requested Se solicitaron cambios labels Sep 25, 2024
@aldoEMatamala aldoEMatamala requested a review from MCele September 25, 2024 13:47
@aldoEMatamala aldoEMatamala force-pushed the RUP-415 branch 2 times, most recently from 4bd1927 to 9ec2c89 Compare September 25, 2024 17:17
@aldoEMatamala
Copy link
Contributor Author

imagen

@aldoEMatamala aldoEMatamala added the test ok Los test estan ok label Sep 25, 2024
@negro89 negro89 added the dependencies Requiere incorporar otra funcionalidad label Oct 8, 2024
@negro89
Copy link
Contributor

negro89 commented Oct 8, 2024

Esperando PR de la tarea https://proyectos.andes.gob.ar/browse/RUP-423

@MCele
Copy link
Contributor

MCele commented Dec 27, 2024

ya está mergeado andes/api#1978, por lo que creo que no tiene dependencias

@MCele MCele removed the dependencies Requiere incorporar otra funcionalidad label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agustin1996ra agustin1996ra agustin1996ra approved these changes

@Fabio-Ramirez Fabio-Ramirez Fabio-Ramirez approved these changes

@MCele MCele MCele approved these changes

@negro89 negro89 Awaiting requested review from negro89 negro89 is a code owner automatically assigned from andes/code-review

Assignees
No one assigned
Labels
Aprobado test ok Los test estan ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aldoEMatamala @negro89 @MCele @Fabio-Ramirez @agustin1996ra