CIT - Notificaciones: limpiar código innecesario #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabio-Ramirez
approved these changes
Dec 17, 2024
ma7payne
requested changes
Dec 19, 2024
| idTurno: turno.id, | ||
| avisoSuspension: aviso | ||
| }; | ||
| this.turnosService.patch(this.agenda.id, idBloque, turno.id, data).subscribe(resultado => { |
There was a problem hiding this comment.
@JuanIRamirez Veo en esta linea dos subscribe anidados, lo que resulta mala practica porque permite la fuga de memoria y dificultad para el manejo de errores. En su lugar se puede optar por pipe + switchMap o similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/CIT-355
Funcionalidad desarrollada
suspender-agenda.
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion