Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONITOREO - Agregar opción para dar de baja un elementoRUP #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maring0019
Copy link
Contributor

Requerimiento

https://proyectos.andes.gob.ar/browse/MONIT-56

Funcionalidad desarrollada

  1. Se agrega el botón eliminar para desactivar un elemento rup.
  2. Se pone el campo activo=false.

UserStory llegó a completarse

  • Si
  • No
  • No corresponde

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

  • Si
  • No

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

@silviroa
Copy link
Contributor

silviroa commented Aug 7, 2023

USUARIO: mbenicio
BUILD NUMBER: 9366
CYPRESS RUN: 8503
TEST START: 2023-08-07T18:51:01.781Z
TOTAL: 403
SUCCESS: 400
FAIL: 1
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Aug 7, 2023

USUARIO: mbenicio
BUILD NUMBER: 9367
CYPRESS RUN: 8504
TEST START: 2023-08-07T19:04:21.722Z
TOTAL: 403
SUCCESS: 400
FAIL: 1
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Aug 8, 2023

USUARIO: mbenicio
BUILD NUMBER: 9369
CYPRESS RUN: 8506
TEST START: 2023-08-08T12:16:45.431Z
TOTAL: 374
SUCCESS: 367
FAIL: 5
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Aug 8, 2023

USUARIO: mbenicio
BUILD NUMBER: 9371
CYPRESS RUN: 8508
TEST START: 2023-08-08T13:43:15.258Z
TOTAL: 390
SUCCESS: 387
FAIL: 1
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Aug 8, 2023

USUARIO: mbenicio
BUILD NUMBER: 9372
CYPRESS RUN: 8509
TEST START: 2023-08-08T13:56:35.011Z
TOTAL: 338
SUCCESS: 318
FAIL: 18
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Aug 8, 2023

USUARIO: mbenicio
BUILD NUMBER: 9373
CYPRESS RUN: 8510
TEST START: 2023-08-08T14:49:16.861Z
TOTAL: 399
SUCCESS: 393
FAIL: 4
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Aug 9, 2023

USUARIO: mbenicio
BUILD NUMBER: 9376
CYPRESS RUN: 8513
TEST START: 2023-08-09T03:05:57.659Z
TOTAL: 335
SUCCESS: 318
FAIL: 15
SKIPPED: 2

@silviroa
Copy link
Contributor

USUARIO: mbenicio
BUILD NUMBER: 9393
CYPRESS RUN: 8530
TEST START: 2023-08-11T15:03:40.166Z
TOTAL: 403
SUCCESS: 400
FAIL: 1
SKIPPED: 2

@silviroa
Copy link
Contributor

USUARIO: mbenicio
BUILD NUMBER: 9405
CYPRESS RUN: 8542
TEST START: 2023-08-14T14:19:17.256Z
TOTAL: 274
SUCCESS: 242
FAIL: 31
SKIPPED: 1
⚠️⚠️⚠️⚠️
Hay archivos que no corrieron. Vuelva a intentar.

@@ -39,4 +39,24 @@ export class RUPElementosRupListadoComponent implements OnInit {
goto(url) {
this.router.navigate([url]);
}

removeElemento(elementoRup: any) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya que existe una interfaz de los elementos de RUP, remplazar el "any" por dicha interfaz.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya que existe una interfaz de los elementos de RUP, remplazar el "any" por dicha interfaz.

Cambios hechos.

elementoRup.activo = false;
this.elementosRupService.save(elementoRup).subscribe(() => {
this.elementosRupService.refresh.next(null);
this.plex.toast('success', 'El elemento se borro correctamente', 'Información', 2000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya que estamos agregar acento a la palabra borró.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya que estamos agregar acento a la palabra borró.

Cambios hechos.

@MarianoCampetella MarianoCampetella added the changes requested Se solicitaron cambios label Aug 14, 2023
@silviroa
Copy link
Contributor

USUARIO: mbenicio
BUILD NUMBER: 9407
CYPRESS RUN: 8544
TEST START: 2023-08-14T14:45:47.019Z
TOTAL: 403
SUCCESS: 400
FAIL: 1
SKIPPED: 2

@maring0019 maring0019 added changes done Se realizaron los cambios pedidos. and removed changes requested Se solicitaron cambios labels Aug 16, 2023
@maring0019 maring0019 force-pushed the MONIT-56 branch 2 times, most recently from 21cb9a0 to 23ef4a3 Compare August 17, 2023 12:09
@silviroa
Copy link
Contributor

USUARIO: mbenicio
BUILD NUMBER: 9467
CYPRESS RUN: 8594
TEST START: 2023-08-17T17:50:24.759Z
TOTAL: 403
SUCCESS: 401
FAIL: 0
SKIPPED: 2

@maring0019 maring0019 force-pushed the MONIT-56 branch 2 times, most recently from 77ae70e to bf3a677 Compare September 13, 2023 16:30
@silviroa
Copy link
Contributor

silviroa commented Mar 7, 2024

Para subir esta funcionalidad primero hay que agregar un control del lado de la app ANDES para que si un elementoRUP deja de estar activo, no permita crear nuevos registros, pero que si se pueda usar para visualizar los datos ya registrados usando el elemento.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes done Se realizaron los cambios pedidos. pausado test ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants