Reverse loop over messages to find quoted message. Improves performance as quoted messages will be near the current message (end of the messages iterator). #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a large chat (250k+ messages) takes a long time. One of reasons for this is the loop which tries to find a quoted message. This loop starts from the beginning of the messages and loops to the end. Almost always one will quote a recent message (near the end of the messages vector). I changed findMessageById method to findMessageByIdReverse so it runs from the end of the vector to the front. This greatly improves performance as the quoted messages is often found in a couple of iterations.