Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse loop over messages to find quoted message. Improves performance as quoted messages will be near the current message (end of the messages iterator). #147

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nielsderdaele
Copy link

Opening a large chat (250k+ messages) takes a long time. One of reasons for this is the loop which tries to find a quoted message. This loop starts from the beginning of the messages and loops to the end. Almost always one will quote a recent message (near the end of the messages vector). I changed findMessageById method to findMessageByIdReverse so it runs from the end of the vector to the front. This greatly improves performance as the quoted messages is often found in a couple of iterations.

@Adair-GA Adair-GA mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant