Fix code scanning alert no. 1: Use of insecure SSL/TLS version #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/andreasgriffin/bitcoin-safe/security/code-scanning/1
To fix the problem, we need to ensure that the SSL context explicitly disallows insecure TLS versions and only allows TLS 1.2 or higher. This can be done by setting the
minimum_versionattribute of the SSL context tossl.TLSVersion.TLSv1_2.The best way to fix the problem without changing existing functionality is to modify the SSL context creation in the
get_electrum_server_versionfunction. Specifically, we will set theminimum_versionattribute of the context tossl.TLSVersion.TLSv1_2right after creating the context withssl.create_default_context().Suggested fixes powered by Copilot Autofix. Review carefully before merging.