Make SwiftYNABError public & throw .apiError #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or type. - Added fix to show API errors when Client request is made. If ErrorDetails cannot be decoded from payload, will fall back to .httpError code.
andrebocchini
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @andrebocchini ,
SwiftYNABErrorin my calling code but wasn't able to because it wasn't publicly available. Updated it's accessor topublic.SwiftYNABError.apiErrorwas never thrown byClient. TheErrorDetailsand other infrastructure (unit tests and json files) was in place except the actual impl in the Client.swift 😊. If it's unable to create theErrorDetails, will fallback to.httpError.apiErroris expected.