release works correctly for in-save pokemon

andrewbenington · Dec 17, 2024 · 4ac178a · 4ac178a
1 parent b6a7a19
commit 4ac178a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/app/dev/AppStateDisplay.tsx b/src/app/dev/AppStateDisplay.tsx
@@ -27,7 +27,7 @@ export default function AppStateDisplay() {
       <Card sx={{ margin: 1 }}>
         <InfoGrid data={appState ?? {}} />
       </Card>
-      <Card>
+      <Card style={{ display: 'flex', flexDirection: 'row' }}>
         <DevDataDisplay data={appInfoState} label="App Info State" />
         <DevDataDisplay data={openSavesState} label="Saves/Mons State" />
       </Card>

diff --git a/src/state/openSaves.ts b/src/state/openSaves.ts
@@ -268,14 +268,16 @@ export const openSavesReducer: Reducer<OpenSavesState, OpenSavesAction> = (
     case 'add_mon_to_release': {
       const replacedMon = updateMonInSave(state, undefined, action.payload)
 
-      if (replacedMon && replacedMon instanceof OHPKM) {
+      if (!replacedMon) return { ...state }
+
+      if (replacedMon instanceof OHPKM) {
         const identifier = getMonFileIdentifier(replacedMon)
 
         if (identifier) {
           delete state.modifiedOHPKMs[identifier]
         }
-        state.monsToRelease.push(replacedMon)
       }
+      state.monsToRelease.push(replacedMon)
       return { ...state }
     }
     case 'clear_updated_box_slots': {