Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move px-bench-env.yml back up to root of repository, update README.md, and clean up examples structure #15

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Move px-bench-env.yml back up to root of repository, update README.md, and clean up examples structure #15

merged 5 commits into from
Nov 30, 2023

Conversation

bplein
Copy link
Collaborator

@bplein bplein commented Nov 29, 2023

per our discussion:

  1. Move the configmap YAML back up to the root, as it doesn't change (other than names of storageclasses) on a cloud/environment basis.
  2. Change README steps to reflect the change in file location.
  3. Change AWS specific breadcrumbs to a markdown file

@bplein
Move configmap YAML to root, update README
7f3732c 
Moving the generic px-bench-env.yaml to the root of the repository, as there were no signfiicant differences across different environments. Update the README.md to reflect this change.
@bplein
Move AWS breadcrumbs to a README
400f21f
@bplein bplein requested a review from andrewh1978 November 29, 2023 15:57
andrewh1978
andrewh1978 requested changes Nov 29, 2023
View reviewed changes
Copy link
Owner

@andrewh1978 andrewh1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename examples to docs, README_AWS.md to AWS.md, move it up a directory and lose the aws subdirectory. A flatter structure will be tidier.

@bplein bplein requested a review from andrewh1978 November 30, 2023 17:04
@andrewh1978 andrewh1978 merged commit 6958d43 into andrewh1978:main Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewh1978 andrewh1978 andrewh1978 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bplein @andrewh1978